Add support for makara adapter#257
Merged
adamruzicka merged 1 commit intoDynflow:masterfrom Dec 12, 2017
Merged
Conversation
Makara can be used as a wrapper around the standar ActiveRecord adapter. This patch should allow users using Dynflow while using this adapter. See [1] for such an example. [1] - https://groups.google.com/d/msg/foreman-users/ORak_xvLi-U/Qy56C3SSAAAJ
|
This is great as a workaround (just need to edit the database.yml to include a hosts: entry which Sequel can pickup). Without this builds don't even work full stop, with the inclusion of dynflow into 1.16. So if this could be merged that'd be awesome. |
Contributor
|
@iNecas, @iwalmsley: Thanks for the code and testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makara can be used as a wrapper around the standar ActiveRecord adapter.
This patch should allow users using Dynflow while using this adapter.
See [1] for such an example.
[1] - https://groups.google.com/d/msg/foreman-users/ORak_xvLi-U/Qy56C3SSAAAJ