Skip to content

Added welcome messages#2

Merged
bartgol merged 1 commit intomasterfrom
welcome_messages
Aug 7, 2020
Merged

Added welcome messages#2
bartgol merged 1 commit intomasterfrom
welcome_messages

Conversation

@bartgol
Copy link
Copy Markdown
Contributor

@bartgol bartgol commented Aug 7, 2020

Motivation

Make EKAT more welcoming when a new user opens a PR/issue.

Also, tested that the pull-request template works as expected, and that the link to the contributing file shows up at the bottom.

@bartgol bartgol added the enhancement New feature or request label Aug 7, 2020
@bartgol bartgol requested a review from jeff-cohere August 7, 2020 17:35
@bartgol bartgol self-assigned this Aug 7, 2020
Comment thread .github/config.yml

# Comment to be posted to on first time issues
newIssueWelcomeComment: >
Thanks for opening your first issue here! Be sure to follow the issue template!
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it practical to hyperlink the template?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this message should appear after they picked the template. And the template is already populated in the issue.

Comment thread .github/config.yml

# Comment to be posted to on PRs from first time contributors in your repository
newPRWelcomeComment: >
Thanks for opening this pull request! Please check out our contributing guidelines.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could hyperlink the guidelines here (if it's supported)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow, they get automatically hyperlinked by github anyways. I think it's coded in the app that creates the message (if the contributing guidelines is present in the repo, that is).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the guidelines are linked when opening an issue. Since I already opened a PR, I can't check that.

Copy link
Copy Markdown
Contributor

@jeff-cohere jeff-cohere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested hyperlinks, but I don't know if they work in this environment. Otherwise looks good!

@bartgol bartgol merged commit 52d9cf4 into master Aug 7, 2020
@bartgol bartgol deleted the welcome_messages branch August 7, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants