Merged
Conversation
1) there was a typo in CXX inside a var name; it was spelled CxX. 2) when linking libs, link ekat_test_main *before* any libs passed to the macro, since the user might as for EXCLUDE_TEST_SESSION, and those extra libs might contain the implementation of the test session functions. By linking user provided libs *after* ekat_test_main, dependencies are correctly resolved.
Collaborator
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
Collaborator
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: EKAT_PullRequest_Autotester_Blake
Jenkins Parameters
Build InformationTest Name: EKAT_PullRequest_Autotester_Weaver
Jenkins Parameters
Build InformationTest Name: EKAT_PullRequest_Autotester_Mappy
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
Collaborator
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 4 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: EKAT_PullRequest_Autotester_Blake
Jenkins Parameters
Build InformationTest Name: EKAT_PullRequest_Autotester_Weaver
Jenkins Parameters
Build InformationTest Name: EKAT_PullRequest_Autotester_Mappy
Jenkins Parameters
Console Output (last 100 lines) : EKAT_PullRequest_Autotester_Blake # 87 (click to expand)Console Output (last 100 lines) : EKAT_PullRequest_Autotester_Weaver # 82 (click to expand)Console Output (last 100 lines) : EKAT_PullRequest_Autotester_Mappy # 1 (click to expand) |
jeff-cohere
approved these changes
Oct 12, 2020
Contributor
jeff-cohere
left a comment
jeff-cohere
left a comment
There was a problem hiding this comment.
Darned case sensitivity!
Looks like the mappy failure comes from using an ancient (2.x) version of cmake there.
Contributor
Author
|
Yeah, I realized I did a sloppy job setting up the mappy jenkins stuff. I edited the bowman job, but forgot to update a bunch of stuff, like the modules... :) |
Collaborator
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Collaborator
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: EKAT_PullRequest_Autotester_Blake
Jenkins Parameters
Build InformationTest Name: EKAT_PullRequest_Autotester_Weaver
Jenkins Parameters
Build InformationTest Name: EKAT_PullRequest_Autotester_Mappy
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
Collaborator
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 4 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: EKAT_PullRequest_Autotester_Blake
Jenkins Parameters
Build InformationTest Name: EKAT_PullRequest_Autotester_Weaver
Jenkins Parameters
Build InformationTest Name: EKAT_PullRequest_Autotester_Mappy
Jenkins Parameters
Console Output (last 100 lines) : EKAT_PullRequest_Autotester_Blake # 88 (click to expand)Console Output (last 100 lines) : EKAT_PullRequest_Autotester_Weaver # 83 (click to expand)Console Output (last 100 lines) : EKAT_PullRequest_Autotester_Mappy # 5 (click to expand) |
Contributor
Author
|
Manually retested on mappy, after fixing the jenkins shell script. Tests pass. Merging manually so we don't have to wait till the AT picks it up again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
macro, since the user might as for EXCLUDE_TEST_SESSION, and those extra
libs might contain the implementation of the test session functions.
By linking user provided libs after ekat_test_main, dependencies are
correctly resolved.
Testing
I configured/compiled SCREAM without/with this mod, and this PR fixes config/linking errors I was getting.