Avoid printing lines of tildes in catch2#86
Merged
Conversation
Github parses a line of tilde as a code block opening. If tests output is written in a msg on a PR/issue, this causes parsing mess.
Collaborator
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
jeff-cohere
approved these changes
Feb 17, 2021
Contributor
jeff-cohere
left a comment
jeff-cohere
left a comment
There was a problem hiding this comment.
Approved, subject to successful testing.
Collaborator
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: EKAT_PullRequest_Autotester_Blake
Jenkins Parameters
Build InformationTest Name: EKAT_PullRequest_Autotester_Weaver
Jenkins Parameters
Build InformationTest Name: EKAT_PullRequest_Autotester_Mappy
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
Collaborator
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: EKAT_PullRequest_Autotester_Blake
Jenkins Parameters
Build InformationTest Name: EKAT_PullRequest_Autotester_Weaver
Jenkins Parameters
Build InformationTest Name: EKAT_PullRequest_Autotester_Mappy
Jenkins Parameters
|
Collaborator
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jeff-cohere ]! |
Collaborator
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
Collaborator
|
Merge on Pull Request# 86: IS A SUCCESS - Pull Request successfully merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github parses a line of tilde as a code block opening. If tests output is
written in a msg on a PR/issue, this causes parsing mess.
Motivation
When the AutoTester writes a message on a PR, it adds outputs from the tests in case there are failures, but lines of
~chars mess up the parsing.Related Issues