Skip to content

fix IO define mode errors and clean up formats#362

Merged
philipwjones merged 1 commit intoE3SM-Project:developfrom
philipwjones:omega/io-opts
Apr 1, 2026
Merged

fix IO define mode errors and clean up formats#362
philipwjones merged 1 commit intoE3SM-Project:developfrom
philipwjones:omega/io-opts

Conversation

@philipwjones
Copy link
Copy Markdown

@philipwjones philipwjones commented Mar 15, 2026

Some IO fixes and format changes, including

  • adding fixes to eliminate IO define mode errors
  • adding a per-stream optional file format option
  • updating IO format options to match SCORPIO
  • creating string-to-enum maps to consolidate IO option definitions in IO.h (instead of the various string-to-enum conversion routines) so that various IO format and other options can be changed in one place

Checklist

  • Documentation:
  • Linting
  • Building
    • CMake build does not produce any new warnings from changes in this PR
  • Testing
    • Add a comment to the PR titled Testing with the following:
      • Which machines CTest unit tests
        have been run on and indicate that are all passing.
      • The Polaris omega_pr test suite
        has passed, using the Polaris e3sm_submodules/Omega baseline
      • Document machine(s), compiler(s), and the build path(s) used for -p for both the baseline (Polaris e3sm_submodules/Omega) and the PR build
      • Indicate "All tests passed" or document failing tests
      • Document testing used to verify the changes including any tests that are added/modified/impacted.
      • Performance related PRs: Please include a relevant PACE experiment link documenting performance before and after.

Fixes #356
Fixes #331

  - adds fixes to eliminate IO define mode errors
  - updates IO format options to match SCORPIO
  - creates string-to-enum maps to consolidate option changes
  - adds a per-stream optional file format option
@philipwjones philipwjones self-assigned this Mar 15, 2026
@philipwjones
Copy link
Copy Markdown
Author

Passes Ctests (even repeated Ctests) on PM cpu and gpu.

Copy link
Copy Markdown

@grnydawn grnydawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been successfully tested on PM-GPU and Chrysalis by running ctests, as well as the Polaris omega_nightly test suite.

Copy link
Copy Markdown
Collaborator

@sbrus89 sbrus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes CTests (and repeated CTests) on Frontier CPU and GPU as well as omega_pr suite with baselines on pm-cpu.

@philipwjones philipwjones merged commit 7ed2f4d into E3SM-Project:develop Apr 1, 2026
1 check passed
xylar added a commit to xylar/polaris that referenced this pull request Apr 2, 2026
cbegeman pushed a commit to cbegeman/polaris that referenced this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IOSTREAM CTest fails when re-run Incorrect Handling of NetCDF File Formats in IOStreams and IO Modules

3 participants