Skip to content

Cleanup of omega broadcast and time mgr to remove warnings#402

Open
philipwjones wants to merge 1 commit into
E3SM-Project:developfrom
philipwjones:omega/cleanup-bcast-tmgr
Open

Cleanup of omega broadcast and time mgr to remove warnings#402
philipwjones wants to merge 1 commit into
E3SM-Project:developfrom
philipwjones:omega/cleanup-bcast-tmgr

Conversation

@philipwjones
Copy link
Copy Markdown

@philipwjones philipwjones commented May 8, 2026

  • changes method for retrieving char ptr for string bcast
  • removes some unnecessary warnings from time mgr
  • updates some related test drivers for consistency and to conform to coding conventions

Checklist

  • Linting
  • Building
    • CMake build does not produce any new warnings from changes in this PR
  • Testing
    • Add a comment to the PR titled Testing with the following:
      • Which machines CTest unit tests
        have been run on and indicate that are all passing.
      • The Polaris omega_pr test suite
        has passed, using the Polaris e3sm_submodules/Omega baseline
      • Document machine(s), compiler(s), and the build path(s) used for -p for both the baseline (Polaris e3sm_submodules/Omega) and the PR build
      • Indicate "All tests passed" or document failing tests
        after.

Fixes #336
Fixes #292

   - changes method for retrieving char ptr for string bcast
   - removes some unnecessary warnings from time mgr
   - updates some related test drivers for consistency and to
     conform to coding conventions
@philipwjones
Copy link
Copy Markdown
Author

Passes all ctests on pm-cpu and pm-gpu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

possible misuse of std::string in the MPI_Bcast call in Broadcast.cpp. During testing, CTest reports warnings originating from TimeMgr.cpp

1 participant