Cleanup of omega broadcast and time mgr to remove warnings#402
Open
philipwjones wants to merge 1 commit into
Open
Cleanup of omega broadcast and time mgr to remove warnings#402philipwjones wants to merge 1 commit into
philipwjones wants to merge 1 commit into
Conversation
- changes method for retrieving char ptr for string bcast
- removes some unnecessary warnings from time mgr
- updates some related test drivers for consistency and to
conform to coding conventions
Author
|
Passes all ctests on pm-cpu and pm-gpu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Testingwith the following:have been run on and indicate that are all passing.
has passed, using the Polaris
e3sm_submodules/Omegabaseline-pfor both the baseline (Polarise3sm_submodules/Omega) and the PR buildafter.
Fixes #336
Fixes #292