Skip to content

Fix unresolved path variables during ingestion #182

Merged
tomvothecoder merged 3 commits into
E3SM-Project:mainfrom
tomvothecoder:fix/181-archive-path-substitution
May 12, 2026
Merged

Fix unresolved path variables during ingestion #182
tomvothecoder merged 3 commits into
E3SM-Project:mainfrom
tomvothecoder:fix/181-archive-path-substitution

Conversation

@tomvothecoder
Copy link
Copy Markdown
Collaborator

Description

When DOUT_S_ROOT in env_run*.xml contains unresolved shell variables ($CIME_OUTPUT_ROOT, $CASE), the simulation detail page displays raw variable names instead of actual paths.

This PR adds a post-parse substitution step in the ingestion pipeline that resolves these variables using values extracted from env_build*.xml (CIME_OUTPUT_ROOT) and env_case*.xml (CASE).

Changes:

Checklist

  • Code follows project style guidelines
  • Self-reviewed code
  • No new warnings
  • Tests added or updated (if needed)
  • All tests pass (locally and CI/CD)
  • Documentation/comments updated (if needed)
  • Breaking change noted (if applicable)

Deployment Notes (if any)

No migration or deployment changes needed. Already-ingested simulations with unresolved paths are not retroactively fixed — a re-ingestion would be needed for those.

@tomvothecoder tomvothecoder changed the title fix: substitute unresolved archive path variables during ingestion (#181) Fix unresolved path variables during ingestion May 12, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 58486e79a9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread backend/app/features/ingestion/parsers/case_docs.py Outdated
@tomvothecoder tomvothecoder merged commit cd78490 into E3SM-Project:main May 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Simulation detail page sometimes renders archive path variables unsubstituted

1 participant