-
Notifications
You must be signed in to change notification settings - Fork 0
feat: 스웨거 경로 수정 #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 스웨거 경로 수정 #269
Conversation
Summary of ChangesHello @yongjun0511, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 도메인 변경에 따른 스웨거 경로의 유연한 관리를 위해 설정 파일을 업데이트합니다. 기존에 하드코딩되어 있던 스웨거 URL을 환경 변수를 통해 동적으로 설정할 수 있도록 변경하여, 배포 환경에 따라 쉽게 경로를 조정할 수 있도록 개선했습니다. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. 환경 변수, 경로를 유연하게, 배포는 쉬워라. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
스웨거 URL 설정을 하드코딩된 값에서 환경 변수를 사용하도록 변경하여 구성의 유연성을 높인 점이 좋습니다. 다만, ..._DOMAIN이라는 변수명이 프로토콜을 포함한 전체 URL을 값으로 가질 경우 혼란을 야기할 수 있어, 설정 파일에서 프로토콜을 명시적으로 추가하고 환경 변수에는 순수 도메인만 저장하도록 변경하는 것을 제안했습니다. 이를 통해 설정의 명확성을 높이고 잠재적인 설정 오류를 방지할 수 있습니다.
| #Swagger | ||
| swagger: | ||
| url: https://dev.eat-ssu.store | ||
| url: ${EATSSU_DEV_DOMAIN} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| #Swagger | ||
| swagger: | ||
| url: https://eat-ssu.store | ||
| url: ${EATSSU_PROD_DOMAIN} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#️⃣ Issue Number
📝 요약(Summary)
💬 공유사항 to 리뷰어
✅ PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.