-
Notifications
You must be signed in to change notification settings - Fork 0
fix: reviewCount, starCount 안맞는 문제 수정 #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @JjungminLee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 리뷰 수와 별점 통계가 실제 데이터와 일치하지 않던 버그를 수정합니다. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. 버그는 숨어 계산은 다시 정확히 별점 빛나리 Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
안녕하세요. PR을 잘 살펴보았습니다. ReviewCalculator를 도입하여 리뷰 및 평점 계산 로직을 중앙화하고, 데이터 불일치 문제를 해결한 점이 인상적입니다. 이는 코드의 응집도를 높이고 유지보수성을 향상시키는 좋은 리팩토링입니다.
다만, 버그 수정과 관련된 중요한 로직 변경임에도 불구하고 테스트 코드가 추가되지 않은 점이 아쉽습니다. RatingCalculator의 정확성을 검증하고 향후 회귀를 방지하기 위해 테스트 케이스를 보강해주시면 코드의 안정성이 더욱 높아질 것입니다. 이는 high 수준의 개선 사항으로 보입니다.
이 외에 몇 가지 코드 개선 제안을 코멘트로 남겼으니 참고 부탁드립니다.
| private final ApplicationEventPublisher eventPublisher; | ||
|
|
||
| private final RatingCalculator ratingCalculator; | ||
| private final MealRatingService mealRatingService; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Integer likeCount = Optional.of(menus) | ||
| .orElse(Collections.emptyList()) | ||
| .stream() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#️⃣ Issue Number
📝 요약(Summary)
💬 공유사항 to 리뷰어
✅ PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.