Skip to content

Conversation

@Funital
Copy link
Collaborator

@Funital Funital commented Jun 29, 2025

  • 리뷰가 있지만 UI 출력이 안되는 오류 수정

#289

#️⃣ 관련 이슈

Resolved #이슈번호

💡작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

  • "null 값에 대해 옵셔널 처리가 안 되어 있어 map() 도중 실패함" 이라는 오류가 떠서 리뷰가 있어도 Table이 UI에 출력이 안되었다.
  • 현재 전달되는 유저의 리뷰 이미지 부분이 null로 되어있어서 ReviewTableCell에 이미지url 부분을 옵셔널(?) 처리를 해줬다.

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

- 리뷰가 있지만 UI 출력이 안되는 오류 수정

#289
@Funital Funital requested review from CJiu01 and Hrepay June 29, 2025 13:10
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Funital, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug preventing review content from displaying on the UI due to improper handling of null image URLs. It updates the data model to correctly represent optional image URLs and refines the UI rendering logic to safely process these optional values, ensuring reviews with missing image data are still displayed correctly.

Highlights

  • Data Model Update: Modified the ReviewListResponse data structure to allow imgURLList to contain optional String values, accommodating cases where image URLs might be null from the backend.
  • UI Robustness: Enhanced the ReviewTableCell's image display logic to gracefully handle null or empty image URLs within the imgURLList, preventing UI display errors when review images are missing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug where the review page would crash when the API returned null for image URLs. The changes include updating the ReviewListResponse DTO to handle optional URL strings and modifying the ReviewTableCell to process this data safely. A suggestion has been made to refactor the image handling logic for improved clarity.

Comment on lines 241 to 243
if let firstImageUrl = response.imgURLList.first(where: { ($0 ?? "").isEmpty == false }) {
foodImageView.isHidden = false
foodImageView.kfSetImage(url: firstImageUrl)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using compactMap can simplify the logic for finding the first non-empty image URL. It removes nil values and directly checks for emptiness, improving readability.

        if let firstImageUrl = response.imgURLList.compactMap({ $0 }).first(where: { !$0.isEmpty }) {
            foodImageView.isHidden = false
            foodImageView.kfSetImage(url: firstImageUrl)
        }

@Funital Funital self-assigned this Jun 29, 2025
Copy link
Collaborator

@CJiu01 CJiu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 바로 배포진행해주시면 됩니다!
수고하셨습니다.

Comment on lines +241 to +243
if let firstImageUrl = response.imgURLList.compactMap({ $0 }).first(where: { !$0.isEmpty }) {
foodImageView.isHidden = false
foodImageView.kfSetImage(url: firstImageUrl)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Funital Funital merged commit 225adda into develop Jun 30, 2025
@Funital Funital deleted the hotfix/#289 branch June 30, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants