-
Notifications
You must be signed in to change notification settings - Fork 1
[#289]: 리뷰페이지 에러 수정 #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#289]: 리뷰페이지 에러 수정 #290
Conversation
- 리뷰가 있지만 UI 출력이 안되는 오류 수정 #289
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Funital, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical bug preventing review content from displaying on the UI due to improper handling of null image URLs. It updates the data model to correctly represent optional image URLs and refines the UI rendering logic to safely process these optional values, ensuring reviews with missing image data are still displayed correctly.
Highlights
- Data Model Update: Modified the
ReviewListResponsedata structure to allowimgURLListto contain optionalStringvalues, accommodating cases where image URLs might benullfrom the backend. - UI Robustness: Enhanced the
ReviewTableCell's image display logic to gracefully handlenullor empty image URLs within theimgURLList, preventing UI display errors when review images are missing.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a bug where the review page would crash when the API returned null for image URLs. The changes include updating the ReviewListResponse DTO to handle optional URL strings and modifying the ReviewTableCell to process this data safely. A suggestion has been made to refactor the image handling logic for improved clarity.
| if let firstImageUrl = response.imgURLList.first(where: { ($0 ?? "").isEmpty == false }) { | ||
| foodImageView.isHidden = false | ||
| foodImageView.kfSetImage(url: firstImageUrl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using compactMap can simplify the logic for finding the first non-empty image URL. It removes nil values and directly checks for emptiness, improving readability.
if let firstImageUrl = response.imgURLList.compactMap({ $0 }).first(where: { !$0.isEmpty }) {
foodImageView.isHidden = false
foodImageView.kfSetImage(url: firstImageUrl)
}- 코드 재수정 #289
CJiu01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다! 바로 배포진행해주시면 됩니다!
수고하셨습니다.
| if let firstImageUrl = response.imgURLList.compactMap({ $0 }).first(where: { !$0.isEmpty }) { | ||
| foodImageView.isHidden = false | ||
| foodImageView.kfSetImage(url: firstImageUrl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
#289
#️⃣ 관련 이슈
Resolved #이슈번호
💡작업 내용
💬리뷰 요구사항(선택)