Skip to content

Conversation

@CJiu01
Copy link
Collaborator

@CJiu01 CJiu01 commented Jul 31, 2025

#️⃣ 관련 이슈

Resolved #295

💡작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

  • 탈퇴하기 provider에 Interceptor를 적용하지 않아, 헤더에 토큰이 담겨보내지지 않는 이슈가 있었습니다. Interceptor를 적용함으로써 이를 해결하였습니다.

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

@CJiu01 CJiu01 self-assigned this Jul 31, 2025
@CJiu01 CJiu01 requested review from Funital and Hrepay July 31, 2025 17:11
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @CJiu01, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug affecting the user withdrawal feature. The core problem stemmed from API requests for withdrawal failing because they lacked the required authentication token. The solution involves a precise modification to the network provider's configuration, enabling proper token handling for this specific functionality.

Highlights

  • Bug Fix: Resolved an issue where the user withdrawal functionality was not working correctly due to the absence of authentication tokens in the request headers.
  • Authentication: Applied the AuthInterceptor.shared to the MoyaProvider instance responsible for user withdrawal requests, ensuring that necessary authentication tokens are now correctly attached to outgoing API calls.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request fixes the user withdrawal functionality by adding the AuthInterceptor to the Moya provider. The review suggests re-introducing the logging plugin that was removed during this change to maintain debuggability.

private var nickName = String()
var currentKeyboardHeight: CGFloat = 0.0
private let myProvider = MoyaProvider<MyRouter>(plugins: [ESMoyaLoggingPlugin()])
private let myProvider = MoyaProvider<MyRouter>(session: Session(interceptor: AuthInterceptor.shared))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The ESMoyaLoggingPlugin was removed when modifying the MoyaProvider. Consider keeping both the authentication interceptor and logging plugin for better debugging. You can configure MoyaProvider to use both session and plugins.

Suggested change
private let myProvider = MoyaProvider<MyRouter>(session: Session(interceptor: AuthInterceptor.shared))
private let myProvider = MoyaProvider<MyRouter>(session: Session(interceptor: AuthInterceptor.shared), plugins: [ESMoyaLoggingPlugin()])

Copy link
Member

@Hrepay Hrepay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

생각보다 간단한 버그였네요! 수고하셨습니다!

@CJiu01
Copy link
Collaborator Author

CJiu01 commented Aug 1, 2025

생각보다 간단한 버그였네요! 수고하셨습니다!

그러게요😅
테스트 코드 작성의 필요성을 느꼈습니다. 이러한 변경이 있을 때, 일일이 기능 테스트를 해볼 수 없으니,,

@CJiu01 CJiu01 merged commit 7e72e16 into develop Aug 1, 2025
@CJiu01 CJiu01 deleted the fix/#295 branch August 1, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix] 탈퇴하기 로직 미작동 이슈

3 participants