-
Notifications
You must be signed in to change notification settings - Fork 1
[#370] 로그인 v2로 변경 #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#370] 로그인 v2로 변경 #371
Conversation
Summary of ChangesHello @Hrepay, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 기존 로그인 기능을 v2 API 버전으로 마이그레이션하는 것을 목표로 합니다. 이를 통해 백엔드와의 통신 규약을 최신화하고, 로그인 요청 시 디바이스 정보를 함께 전달하여 서비스의 유연성을 높였습니다. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. 새로운 길 열어 버전 이젠 v2로 로그인 빛나리 Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이번 PR은 로그인 API를 v2로 업데이트하는 변경사항을 담고 있습니다. 관련하여 AuthRouter의 경로와 AppleLoginRequest, KakaoLoginRequest DTO가 수정되었습니다. 전반적으로 변경 내용은 명확하며, API 변경에 잘 대응하고 있습니다. 다만, 로그인 요청 시 deviceType으로 하드코딩된 문자열 "IOS"를 사용하고 있는데, 이를 상수로 추출하여 관리하면 코드의 유지보수성을 더 높일 수 있을 것 같습니다. 자세한 내용은 각 파일에 남긴 코멘트를 참고해주세요.
EATSSU/App/Sources/Presentation/Auth/ViewController/LoginViewController.swift
Show resolved
Hide resolved
EATSSU/App/Sources/Presentation/Auth/ViewController/LoginViewController.swift
Show resolved
Hide resolved
Funital
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS로 카카오 로그인했음을 명확히 알수 있겠네요!
#️⃣ 관련 이슈
Resolved #370
💡작업 내용
💬리뷰 요구사항(선택)