Skip to content

Conversation

@Hrepay
Copy link
Member

@Hrepay Hrepay commented Dec 30, 2025

#️⃣ 관련 이슈

Resolved #370

💡작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

  • 로그인을 v2 버전으로 변경했습니다.

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

@Hrepay Hrepay requested a review from Funital December 30, 2025 14:13
@Hrepay Hrepay self-assigned this Dec 30, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @Hrepay, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 기존 로그인 기능을 v2 API 버전으로 마이그레이션하는 것을 목표로 합니다. 이를 통해 백엔드와의 통신 규약을 최신화하고, 로그인 요청 시 디바이스 정보를 함께 전달하여 서비스의 유연성을 높였습니다.

Highlights

  • 로그인 API 버전 업데이트: 카카오 및 Apple 로그인 엔드포인트가 /oauths/v2/kakao/oauths/v2/apple로 업데이트되었습니다.
  • 로그인 요청 DTO 변경: AppleLoginRequestKakaoLoginRequest 모델에 deviceType 필드가 추가되었습니다.
  • 디바이스 타입 전송: 로그인 요청 시 deviceType으로 "IOS"를 명시적으로 전송하도록 변경되었습니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


새로운 길 열어 버전 이젠 v2로 로그인 빛나리

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이번 PR은 로그인 API를 v2로 업데이트하는 변경사항을 담고 있습니다. 관련하여 AuthRouter의 경로와 AppleLoginRequest, KakaoLoginRequest DTO가 수정되었습니다. 전반적으로 변경 내용은 명확하며, API 변경에 잘 대응하고 있습니다. 다만, 로그인 요청 시 deviceType으로 하드코딩된 문자열 "IOS"를 사용하고 있는데, 이를 상수로 추출하여 관리하면 코드의 유지보수성을 더 높일 수 있을 것 같습니다. 자세한 내용은 각 파일에 남긴 코멘트를 참고해주세요.

Copy link
Collaborator

@Funital Funital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS로 카카오 로그인했음을 명확히 알수 있겠네요!

@Hrepay Hrepay merged commit 3b5f9c5 into develop Dec 30, 2025
@Hrepay Hrepay deleted the feat/#370 branch December 30, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat] 로그인 V2

3 participants