Skip to content

[#403] 학과 입력하기 버튼 탭 인덱스 수정 (2 → 3)#404

Merged
Hrepay merged 1 commit intodevelopfrom
fix/#403
Mar 16, 2026
Merged

[#403] 학과 입력하기 버튼 탭 인덱스 수정 (2 → 3)#404
Hrepay merged 1 commit intodevelopfrom
fix/#403

Conversation

@Hrepay
Copy link
Copy Markdown
Member

@Hrepay Hrepay commented Mar 16, 2026

#️⃣ 관련 이슈

Resolved #403

💡작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

  • "내 정보" 탭으로 전환할 때 사용하던 탭 인덱스를 2에서 3으로 변경했습니다.
  • setTabgetNavController 양쪽 모두 동일하게 3번 인덱스를 사용하도록 맞췄습니다.
ScreenRecording_03-16-2026.14-28-55_1.MP4

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

  • x

@Hrepay Hrepay requested a review from wjdalswl March 16, 2026 05:30
@Hrepay Hrepay self-assigned this Mar 16, 2026
Copilot AI review requested due to automatic review settings March 16, 2026 05:30
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 "내 정보" 탭으로 이동할 때 발생하는 문제를 해결하기 위해 탭 인덱스를 업데이트합니다. 기존에 잘못 설정된 인덱스로 인해 내비게이션이 올바르게 작동하지 않던 부분을 수정하여, 사용자가 의도한 대로 해당 탭으로 정확히 이동할 수 있도록 개선되었습니다.

Highlights

  • 탭 인덱스 수정: "내 정보" 탭으로 전환할 때 사용되는 탭 인덱스를 2에서 3으로 변경했습니다.
  • 일관성 유지: setTab 메서드와 getNavController 메서드 모두에서 변경된 탭 인덱스(3)를 사용하도록 일관성을 맞췄습니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • EATSSU/App/Sources/Presentation/Map/ViewController/NoDepartmentSheetViewController.swift
    • "내 정보" 탭으로 전환하는 로직에서 탭 인덱스를 2에서 3으로 변경했습니다.
    • tabContainer.setTabtabContainer.getNavController 호출 시 사용되는 인덱스를 업데이트했습니다.
Activity
  • Hrepay님이 풀 리퀘스트를 생성했습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


인덱스 하나, 작은 숫자, 탭 전환 오류를 고쳤네. 이제 "내 정보"로, 정확히 이동하리, 코드의 작은 수정, 큰 기쁨.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a bug where tapping "학과 입력하기" (enter department) from the map's bottom sheet had no effect, by correcting the tab index from 2 to 3 to properly navigate to the "내 정보" (My Info) tab.

Changes:

  • Updated tab index from 2 to 3 in both setTab and getNavController calls to match the actual position of the "My Info" tab.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

PR의 변경 사항을 검토했습니다. 학과 입력 버튼 클릭 시 '내 정보' 탭으로 올바르게 이동하도록 탭 인덱스를 수정한 것을 확인했습니다. 코드의 유지보수성 향상을 위해, 하드코딩된 탭 인덱스 값을 상수로 관리하는 방안에 대한 의견을 리뷰 댓글로 남겼습니다.

Copy link
Copy Markdown
Contributor

@wjdalswl wjdalswl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@Hrepay Hrepay merged commit 3b83b93 into develop Mar 16, 2026
4 checks passed
@Hrepay Hrepay deleted the fix/#403 branch March 16, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix] 지도 내 학과 입력하기 기능 화면 전환 버그

3 participants