Skip to content

Possible extra argument when download_file() called in ecco_podaac_download_subset() #106

@Maddie-Sh

Description

@Maddie-Sh

Hi, thanks for this great package!

While reviewing the "ecco_download.py" file within "ecco_access", I noticed a potential issue within the definition of the ecco_podaac_download_subset() function at the end of the file.

I see that it calls download_file() twice (at lines 1040 and 1052) with the argument show_noredownload_msg=show_noredownload_msg. However, download_file() as it is defined slightly above (at line 990), does not accept this parameter:

    def download_file(url: str, output_file: str, force: bool=False):

Could this be an extra argument from a previous version, or is it something missing in the function definition? Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions