Skip to content

Fix docker image lowercasing#335

Merged
SunkenSplash merged 4 commits into
devfrom
fix/lowercase-refs-release-action
May 1, 2026
Merged

Fix docker image lowercasing#335
SunkenSplash merged 4 commits into
devfrom
fix/lowercase-refs-release-action

Conversation

@SunkenSplash
Copy link
Copy Markdown
Member

See title.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions release workflow to ensure GHCR image names use a lowercased repository owner, avoiding failures when the owner contains uppercase characters.

Changes:

  • Add a per-job step to normalize github.repository_owner to lowercase and expose it via step outputs.
  • Update docker metadata/image references and multi-arch manifest creation to use the normalized owner.
  • Update digest inspection targets to match the new normalized image paths.
Comments suppressed due to low confidence (1)

.github/workflows/release.yml:300

  • These image references are now hardcoded to .../${{ steps.owner.outputs.owner }}/hums-server instead of using the existing env vars (SERVER_IMAGE_NAME/MIGRATE_IMAGE_NAME/WEB_IMAGE_NAME), and those env vars appear to be unused after this change. This increases duplication and makes future renames harder. Consider either removing the unused env vars or setting normalized image name env vars (via $GITHUB_ENV) and using them consistently throughout the workflow (build, manifest, and any documentation steps).
          images: ${{ env.REGISTRY }}/${{ steps.owner.outputs.owner }}/hums-server
          tags: |
            type=raw,value=${{ needs.create-release.outputs.tag }}-${{ matrix.arch }},priority=900
            type=raw,value=v${{ needs.create-release.outputs.version }}-${{ matrix.arch }},priority=850
            type=raw,value=latest-${{ matrix.arch }},priority=600

Comment thread .github/workflows/release.yml Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SunkenSplash SunkenSplash merged commit ee0bc1a into dev May 1, 2026
3 checks passed
@SunkenSplash SunkenSplash mentioned this pull request May 1, 2026
SunkenSplash added a commit that referenced this pull request May 4, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants