Feature/197 speech hotkeys rebased#2738
Merged
Merged
Conversation
# Conflicts: # EddiCore/EDDI.cs
(does not yet save or load any configuration info)
Add a `Clear` button and classes to help manage hotkey data. Improve tests for valid key gestures and feedback for invalid gestures.
… and perform the registration only after the user accepts the hotkeys.
WPF controls must be created in a STA (single-threaded apartment) thread. We use `STATestClass` instead of `TestClass` to ensure this. See https://www.meziantou.net/mstest-v2-customize-test-execution.htm - however since that article was written MS has incorporated the solution into the MSTest framework.
We need to take copies of the name and gesture before unregistering and re-registering.
Exposing a mutable collection as a property never ends well. Instead, keep the collection private and write methods for Add, Remove and Enumerate. Fixes cases where hotkey changes were not getting written to disk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now rebased and internationalized.