Set oxygen limitation to 1 when decomp_scheme is 3 and 4 #427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think this was a copy/paste typo as the code was identical to water limitation. The comment above the code suggested that the idea was to set oxygen limitation to 1 (i.e., no oxygen limitation), so this pull request implements what the comment suggested.
@xiangtaoxu I think you are the one who implemented
decomp_scheme = 3anddecomp_scheme = 4, what do you think?Collaborators
Types of changes
Changes in Settings, Input Files or Output Files
Expectation of Answer Changes:
This change is needed because otherwise the oxygen limitation factor may be uninitialised.
Checklist:
Testing :