Skip to content

Conversation

@mpaiao
Copy link
Contributor

@mpaiao mpaiao commented Jan 28, 2026

Description

I think this was a copy/paste typo as the code was identical to water limitation. The comment above the code suggested that the idea was to set oxygen limitation to 1 (i.e., no oxygen limitation), so this pull request implements what the comment suggested.

@xiangtaoxu I think you are the one who implemented decomp_scheme = 3 and decomp_scheme = 4, what do you think?

Collaborators

Types of changes

  • Hot fix (emergential bug fix to make ED2 run again)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (fix or feature that would cause existing functionality to change)

Changes in Settings, Input Files or Output Files

  • This feature requires changes in ED2IN
  • This feature requires changes in the XML parameter file
  • This feature requires changes in other input files
  • This feature will change output files

Expectation of Answer Changes:

  • No changes expected (bit-for-bit compatibility)
  • Changes expected with specific configurations (see details below)
  • Changes expected in all simulations (see details below)

This change is needed because otherwise the oxygen limitation factor may be uninitialised.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • ED2 Wiki update:

Testing :

  • All new and existing tests passed.

I think this was a copy/paste typo, the code was identical to water limitation, but the comment made more sense than the code. 

@xiangtaoxu I think you are the one who implemented this, what do you think?
@xiangtaoxu
Copy link
Contributor

These decomposition schemes were not from me. Based on the annotations above, it might come from Jackie Matthes

!   From Jaclyn Matthes: Empirical equation from meta-analysis in M12.            !
!                                                                                 !
!  Moyano FE, Vasilyeva N, Bouckaert L, Cook F, Craine J, Curiel Yuste J, Don A,  !
!     Epron D, Formanek P, Franzluebbers A et al. 2012. The moisture response of  !
!     soil heterotrophic respiration: interaction with soil properties.           !
!     Biogeosciences, 9: 1173-1182. doi:10.5194/bg-9-1173-2012 (M12).    

I do have read the paper and I agree with you that this is a typo. Oxygen limitation should already be considered in the hump-shaped soil moisture limitation curve

@xiangtaoxu xiangtaoxu merged commit bae4504 into master Jan 29, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants