Create empty eessi_api_metadata_software.json if it does not exist#705
Closed
bedroge wants to merge 1 commit intoEESSI:mainfrom
Closed
Create empty eessi_api_metadata_software.json if it does not exist#705bedroge wants to merge 1 commit intoEESSI:mainfrom
eessi_api_metadata_software.json if it does not exist#705bedroge wants to merge 1 commit intoEESSI:mainfrom
Conversation
ocaisa
reviewed
Mar 17, 2026
| json_file=docs/available_software/data/eessi_api_metadata_software.json | ||
| json_file_orig=${json_file}.orig | ||
| # if the json file does not exist yet, create an empty JSON file | ||
| if [[ ! -f "${json_file}" ]]; then |
Member
There was a problem hiding this comment.
Hmm, this seems wrong. That file is never meant to exist in this repo, it's the files that are generated after processing that file that are important to check for changes
Collaborator
Author
There was a problem hiding this comment.
Ah, yeah, good point... Too focused on trying to fix the old behaviour 😅
I'll close this PR and make a new one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #704 , which still failed because
eessi_api_metadata_software.jsondid not exist in the github repo. Fixed by creating a dummy file if it does not exist, such that a change will be detected and a PR will be opened.