added ansible requirements.yml and update README #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I'll try to test this tomorrow. Since we renamed the name of the galaxyproject.cvmfs role to just cvmfs in our git submodule, we also have to change this back to galaxyproject.cvmfs in all the different playbooks. |
Contributor
Author
|
good point, I missed that. I will try to update the PR |
Collaborator
|
Thanks @pescobar! I've just tested all the playbooks on clean VMs, and everything still seems to work fine. |
Contributor
Author
|
@bedroge if you test the playbook using VMs maybe you are interested on the vagrant file I have in this repo https://github.com/pescobar/ansible-beegfs-vagrant-tests |
Collaborator
|
@pescobar Might be useful, thanks! |
peterstol
pushed a commit
to peterstol/filesystem-layer
that referenced
this pull request
Feb 18, 2021
Change parentheses by curly braces enclosing EPREFIX variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "ansible way" to define dependency roles is to use
ansible-galaxywith arequirements.yml. This way you don't need to worry about git-submodules and mainly you improve reproducibility because you can fix which version of the role you are using instead of pointing to master.Another possible improvement for reproducibility could be to provide a pip
requirements.txtwhich defines the specific ansible and python libraries that are tested to run the playbook but that's probably something for a different PR in case you are interested.