add Dockerfile for container providing easy access to EESSI pilot repository #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@bedroge Let's merge this, container for clients that want to play with the pilot repo has proved to be working well? |
bedroge
requested changes
Sep 21, 2020
Collaborator
bedroge
left a comment
bedroge
left a comment
There was a problem hiding this comment.
Looks good to me, except that I have another PR (#36) which also adds files to this containers dir. That PR uses a README.md, though. Can we try making them compatible, by for instance renaming your README to README.md and describing this container in a specific section?
containers/README
Outdated
| @@ -0,0 +1,5 @@ | |||
| Docker container to provide easy access to EESSI pilot repository, | |||
| see https://hub.docker.com/repository/docker/eessi/client-pilot and https://eessi.github.io/docs/pilot . | |||
Collaborator
There was a problem hiding this comment.
You will really have to make my day first ;-)
Suggested change
| see https://hub.docker.com/repository/docker/eessi/client-pilot and https://eessi.github.io/docs/pilot . | |
| see https://hub.docker.com/repository/docker/eessi/client-pilot and https://eessi.github.io/docs/pilot. |
…and + use latest cvmfs-config-eessi RPM
boegel
force-pushed
the
docker_client_pilot
branch
2 times, most recently
from
85f2c91 to
308bd93
Compare
boegel
force-pushed
the
docker_client_pilot
branch
from
308bd93 to
350ff10
Compare
boegel
changed the title
Contributor
Author
|
@bedroge I think this is good to go now... |
bedroge
requested changes
Oct 13, 2020
Co-authored-by: Bob Dröge <b.e.droge@rug.nl>
… to download it first
boegel
force-pushed
the
docker_client_pilot
branch
from
543761b to
07f3318
Compare
bedroge
approved these changes
Oct 15, 2020
Collaborator
bedroge
left a comment
bedroge
left a comment
There was a problem hiding this comment.
Haven't been able to test the Arm image on my RPi, but it looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't include
fuse-overlayfs, since pure clients don't really need that.