Add Github Action for Ansible Lint #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Here' s an example: |
Contributor
|
Hmm, I would expect the actions to be used already in this pull request, but it's possible that's not done because of security reasons (so you can't open a PR with a malicious action or so). Looks good to me, so let's merge this and see what happens. :) |
boegel
approved these changes
Jun 5, 2020
boegel
reviewed
Jun 5, 2020
| on: [push, pull_request] | ||
|
|
||
| jobs: | ||
| build: |
Contributor
There was a problem hiding this comment.
@bedroge Can you rename this to ansible-lint in a follow-up PR where you fix the linting issues?
Once that is merged, I'll change the requirements for the master branch that the linter check passes before PRs can be merged...
peterstol
pushed a commit
to peterstol/filesystem-layer
that referenced
this pull request
Feb 18, 2021
fix determining shell in bootstrap_startscript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought it would be useful to check/lint the playbooks that we commit. @boegel I only have limited experience with Github Action, so could you have a look at this? I left some code smells in my playbook, so that you can (hopefully) see what it does. (or not, probably only works after the PR gets accepted?)