Skip to content

add eessi-upload-to-staging script to build container#91

Merged
bedroge merged 12 commits intoEESSI:mainfrom
boegel:build_container_upload
Sep 10, 2021
Merged

add eessi-upload-to-staging script to build container#91
bedroge merged 12 commits intoEESSI:mainfrom
boegel:build_container_upload

Conversation

@boegel
Copy link
Copy Markdown
Contributor

@boegel boegel commented Sep 4, 2021

draft PR, not tested yet...

This makes uploading tarball of additional software installations a bit easier, no need to copy stuff around first...

@boegel boegel marked this pull request as ready for review September 4, 2021 13:57
@boegel boegel requested a review from bedroge September 4, 2021 13:57
RUN useradd -ms /bin/bash eessi

# see https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2-linux.html#cliv2-linux-install
RUN curl https://awscli.amazonaws.com/awscli-exe-linux-$(uname -m)-2.2.35.zip -o awscliv2.zip \
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we avoid hard coding the version number?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually prefer hardcoding it, to have control over what we install exactly...

But I'm happy to drop this, and always install latest instead.

Copy link
Copy Markdown
Member

@terjekv terjekv Sep 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, no, I ment we should store it in a variable or similar. We should certainly not just grab latest. I was thinking we could have a master list of versions of things like AWScli, fuse overlay, and other tools we rely on. If nothing else simply to ensure that we know what worked[tm] back in the day.

terjekv
terjekv previously approved these changes Sep 4, 2021
bedroge
bedroge previously approved these changes Sep 6, 2021
bedroge
bedroge previously approved these changes Sep 6, 2021
@bedroge
Copy link
Copy Markdown
Collaborator

bedroge commented Sep 6, 2021

@boegel the check is failing on ppc64le because of:

 > [stage-1 10/11] RUN curl https://awscli.amazonaws.com/awscli-exe-linux-$(uname -m)-2.2.35.zip -o awscliv2.zip   && unzip awscliv2.zip   && ./aws/install   && rm -r aws:

  0  5795    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  5795  100  5795    0     0   9198      0 --:--:-- --:--:-- --:--:--  9392
#15 0.929 Archive:  awscliv2.zip
#15 0.930   End-of-central-directory signature not found.  Either this file is not
#15 0.930   a zipfile, or it constitutes one disk of a multi-part archive.  In the
#15 0.930   latter case the central directory and zipfile comment will be found on
#15 0.930   the last disk(s) of this archive.
#15 0.931 unzip:  cannot find zipfile directory in one of awscliv2.zip or
#15 0.931         awscliv2.zip.zip, and cannot find awscliv2.zip.ZIP, period.

@terjekv
Copy link
Copy Markdown
Member

terjekv commented Sep 6, 2021

ppc64le (or POWER at all) is not a supported platform for awscli: https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2-linux.html#cliv2-linux-install

Thankfully AWS wants aarch64 for arm, so that should work.

@bedroge
Copy link
Copy Markdown
Collaborator

bedroge commented Sep 7, 2021

The pip package does seem to work on ppc64le, so maybe we could use do pip install awscli instead?

@boegel
Copy link
Copy Markdown
Contributor Author

boegel commented Sep 10, 2021

The pip package does seem to work on ppc64le, so maybe we could use do pip install awscli instead?

Yes, and there's actually other good reasons to stick to awscli 1.x (which is available through PyPI, 2.x is not), grab a ☕ and go read aws/aws-cli#4947...

Copy link
Copy Markdown
Collaborator

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bedroge bedroge merged commit 2575066 into EESSI:main Sep 10, 2021
@boegel boegel deleted the build_container_upload branch September 10, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants