fix script to init EESSI for csh shells, fixes also the CI for csh and speeds up CI
#102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocaisa
reviewed
Oct 6, 2025
| - name: Check out software-layer repository | ||
| uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 | ||
|
|
||
| - name: Avoid processing man-db trigger |
Member
There was a problem hiding this comment.
This is good, I'm going to steal this for the EESSI GitHub Action
Contributor
There was a problem hiding this comment.
Is the slow-down caused by the sudo apt install zsh ksh fish tcsh below?
Member
There was a problem hiding this comment.
It's a general thing, slow is relative, it typically 20-30 second for updating man-db, which we will never use so might as well disable it.
Contributor
Author
MaKaNu
approved these changes
Oct 9, 2025
Contributor
MaKaNu
left a comment
MaKaNu
left a comment
There was a problem hiding this comment.
Looks fine from my side. Congrats for taming this csh.
Contributor
There was a problem hiding this comment.
@trz42 it seems you are way more talented than me, to handle csh error message.
After all the "Illegal variable name." and "then: then/endif not found" error messages, I am happy to see this script finally working correctly.
ocaisa
approved these changes
Oct 9, 2025
Member
ocaisa
left a comment
ocaisa
left a comment
There was a problem hiding this comment.
LGTM, now needs to be deployed...
Member
|
bot: build repo:eessi.io-2025.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
|
New job on instance
|
|
New job on instance
|
Member
|
Deployment PR merged |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The init script for
csh, e.g.,/cvmfs/software.eessi.io/versions/2023.06/init/lmod/csh, wasn't working properly (some syntax issues with oneliners forif-then-endifconstructs as well as slightly off syntax for running commands (cshuses backticks and does not support$(...)syntax).CI for
cshwas fixed, mostly by adjusting to different syntax required and working around that - in non-interactive shells - aliases (such asmodule) aren't retained for subsequent commands after sourcing the init script. Some polishing was applied to the test script (test_init_scripts.sh) as well (mostly replacing tabs with spaces).Finally, installation of CernVM-FS (and other packages) was sped up by preventing the processing of the
man-dbtrigger. Unless we needmanpages in CI this should be fine. Note, only for the workflowtests_init_module.yml.