-
Notifications
You must be signed in to change notification settings - Fork 15
Disable --with-sysroot option for UCX
#133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
|
New job on instance
|
|
New job on instance
|
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
|
New job on instance
|
|
New job on instance
|
|
So, UCX builds fine without the bot: build repo:eessi.io-2025.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
|
New job on instance
|
|
Also just checked the No more paths starting with a |
|
That also worked, so let's do the final build. bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
|
New job on instance
|
|
New job on instance
|
ocaisa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@bedroge Did you check the details on why we started using I'm not opposing this change, but we should try and make try and make sure it won't hit us in the face somewhere else later... |
Couldn't really find a particular reason, only the comment in the hooks file itself. It seems like it was added in EESSI/software-layer#75, but that doesn't say anything about it either. |
|
Also see EESSI/software-layer#63. It was probably added in an attempt to pick up the right rdmacm libraries, but I don't think this flag was required for that (as I apparently had already suggested in that PR). |
|
Updated hooks have been ingested, so this can be merged... |
In both EESSI/software-layer#1299 (comment) and EESSI/software-layer#1294 we've seen the following error for applications that try to link against UCX:
UCX's
$EBROOTUCX/lib/*.lafiles contain these paths prefixed with a=, which are, according to ChatGPT, "paths relative to the installed libdir of this library". They're not relative though, but absolute paths, and this seems to be caused by the--with-sysrootoption. Compiling it without that option should be fine, it should even use the compiler's sysroot in this case:To make sure that this works, I'll do test builds of a few UCX versions here.