Always use fuse mounts by default in EESSI container, only use bind mounts when explicitly requested #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-jsc architecture:aarch64/nvidia/grace |
|
New job on instance
edit: this failed because of issues with the EB configuration, not caused by this PR. |
bedroge
force-pushed
the
bind_mount_optional
branch
from
9e60de2 to
51d3d91
Compare
Contributor
Author
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-jsc architecture:aarch64/nvidia/grace |
|
New job on instance
|
Contributor
Author
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-jsc architecture:aarch64/nvidia/grace |
|
New job on instance
|
Contributor
Author
|
I've made some additional changes in 6610e7e, as I just found other parts in the scripts where we loop over the repositories and where it only checked for |
Contributor
Author
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-jsc architecture:aarch64/nvidia/grace |
|
New job on instance
|
casparvl
approved these changes
Aug 5, 2025
Contributor
casparvl
left a comment
casparvl
left a comment
There was a problem hiding this comment.
I think we should also investigate if we can somehow do bind-mounting on hosts that have the repo mounted and have a non-standard host-injections, this solves some immediate build issues. Looks good to me, test by Bob was succesful.
I've removed the cowsay test easystack, hope that's ok with you @bedroge , but then it can be merged right away :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #56 by reverting the change which made bind mounts the default on systems where
/cvmfs/software.eessi.iomounted on the host. This could cause issues with the host injections folder, if this system uses a non-standard path (something else than/opt/eessi).Bind mounts can still be used, but have to be explicitly enabled by using something like:
./eessi_container.sh -r myrepo,mount=bindAlso improves the parsing of some variables, which could have a trailing newline in case they are the last/only argument. It's removing them using
${myvar%$'\n'}(see https://unix.stackexchange.com/a/57128).