Skip to content

CI check for avoiding duplicate directory bot errors#1464

Merged
bedroge merged 5 commits intoEESSI:mainfrom
agimenog:bot_script_ci
Apr 15, 2026
Merged

CI check for avoiding duplicate directory bot errors#1464
bedroge merged 5 commits intoEESSI:mainfrom
agimenog:bot_script_ci

Conversation

@agimenog
Copy link
Copy Markdown
Contributor

@agimenog agimenog commented Apr 9, 2026

Hi,

Related to the following ticket: https://gitlab.com/eessi/support/-/work_items/241

A CI check that clones software-layer-scripts repo and runs the symlink commands.

@casparvl casparvl requested a review from bedroge April 14, 2026 09:12
Comment thread .github/workflows/bot_build.yml Outdated

steps:
- name: Checkout repo
uses: actions/checkout@v4
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For security reasons we usually stick to a commit of actions (see e.g. https://github.com/EESSI/software-layer/blob/main/.github/workflows/test-software.eessi.io.yml#L48), could you do the same here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Already modified, could you check again?

@bedroge
Copy link
Copy Markdown
Collaborator

bedroge commented Apr 15, 2026

Lgtm, but I'll do a test by (temporarily) adding a file that exists in software-layer-scripts, just to make sure that the CI will then indeed fail.

@bedroge
Copy link
Copy Markdown
Collaborator

bedroge commented Apr 15, 2026

The CI failed, as expected:

ln: failed to create symbolic link './EESSI-install-software.sh': File exists

Comment thread .github/workflows/bot_build.yml Outdated
Copy link
Copy Markdown
Collaborator

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bedroge bedroge merged commit 48d68de into EESSI:main Apr 15, 2026
59 checks passed
@agimenog agimenog deleted the bot_script_ci branch April 16, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants