update contributing.md for installer-gui#999
Merged
Merged
Conversation
untitaker
approved these changes
Apr 24, 2026
Collaborator
untitaker
left a comment
untitaker
left a comment
There was a problem hiding this comment.
i wonder if we should restructure installer-gui so that its toml is at the same folder level as the rest of the workspace crates. then */Cargo.toml will match
Member
Author
|
we could try it! my only concerns are idk how difficult it is (might be easy, idk) and it might be awkward when working on the GUI since we normally interact with tauri through npm commands like the approach i had in mind if we wanted to automate this more would be to create a trivial release script under scripts/ or tools/ that does the version bump. i think another thing nice about this approach is the current sed command doesn't work with GNU sed so having a more portable way to do this seems nice to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this could and should be automated better imo, but we should at least make sure our docs are correct here