Stabilize RelationalExtensions#56
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes the relational EF Core extensions by making window-function failures more actionable, expanding validation/tests around window-function behavior, and updating package/docs messaging to present the feature as established rather than experimental.
Changes:
- Added translation-time validation and clearer direct-invocation exceptions for
WindowFunction.*APIs. - Added analyzer and test coverage for invalid literal arguments and several integration tests for ranking/navigation edge cases.
- Updated package metadata and documentation to remove experimental wording and broaden the described feature set.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/ExpressiveSharp.Tests/RelationalExtensions/WindowFunctionStubInvocationTests.cs | Adds tests for improved direct-invocation exception messages on window-function stubs. |
| tests/ExpressiveSharp.Generator.Tests/CodeFixers/WindowFunctionLiteralArgsAnalyzerTests.cs | Adds analyzer tests for invalid literal bucket/offset arguments. |
| tests/ExpressiveSharp.EntityFrameworkCore.IntegrationTests/Infrastructure/WindowFunctionTestBase.cs | Adds integration tests covering tie-breaking, framing, and translation-time argument validation. |
| src/ExpressiveSharp.EntityFrameworkCore.RelationalExtensions/Infrastructure/Internal/WindowFunctionMethodCallTranslator.cs | Introduces translation-time validation for invalid window-function arguments. |
| src/ExpressiveSharp.EntityFrameworkCore.RelationalExtensions/ExpressiveSharp.EntityFrameworkCore.RelationalExtensions.csproj | Updates package description to reflect the broader supported feature set. |
| src/ExpressiveSharp.EntityFrameworkCore.RelationalExtensions.Abstractions/WindowFunction.cs | Replaces generic stub exceptions with method-specific guidance for direct invocation. |
| src/ExpressiveSharp.EntityFrameworkCore.CodeFixers/WindowFunctionLiteralArgsAnalyzer.cs | Adds Roslyn diagnostics for invalid literal Ntile and Lag/Lead arguments. |
| docs/recipes/window-functions-ranking.md | Removes experimental warning from ranking recipe docs. |
| docs/index.md | Updates homepage package/feature descriptions for relational extensions. |
| docs/guide/window-functions.md | Expands provider notes, validation docs, and upgrade guidance for window functions. |
| docs/guide/quickstart.md | Refreshes package summary text for relational extensions in the quickstart table. |
| docs/advanced/limitations.md | Reframes limitations docs around provider support instead of experimental status. |
| README.md | Removes experimental wording from the top-level feature list. |
| CLAUDE.md | Updates internal repo notes to reflect non-experimental status and new diagnostics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the stability and clarity of the
ExpressiveSharp.EntityFrameworkCore.RelationalExtensionspackage by refining descriptions, improving error handling, and removing experimental warnings. Add tests to ensure proper functionality of window functions.