Skip to content

Stabilize RelationalExtensions#56

Merged
koenbeuk merged 4 commits into
mainfrom
feat/relational-extensions-stable
May 3, 2026
Merged

Stabilize RelationalExtensions#56
koenbeuk merged 4 commits into
mainfrom
feat/relational-extensions-stable

Conversation

@koenbeuk
Copy link
Copy Markdown
Collaborator

@koenbeuk koenbeuk commented May 3, 2026

Enhance the stability and clarity of the ExpressiveSharp.EntityFrameworkCore.RelationalExtensions package by refining descriptions, improving error handling, and removing experimental warnings. Add tests to ensure proper functionality of window functions.

Copilot AI review requested due to automatic review settings May 3, 2026 02:01
@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR stabilizes the relational EF Core extensions by making window-function failures more actionable, expanding validation/tests around window-function behavior, and updating package/docs messaging to present the feature as established rather than experimental.

Changes:

  • Added translation-time validation and clearer direct-invocation exceptions for WindowFunction.* APIs.
  • Added analyzer and test coverage for invalid literal arguments and several integration tests for ranking/navigation edge cases.
  • Updated package metadata and documentation to remove experimental wording and broaden the described feature set.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/ExpressiveSharp.Tests/RelationalExtensions/WindowFunctionStubInvocationTests.cs Adds tests for improved direct-invocation exception messages on window-function stubs.
tests/ExpressiveSharp.Generator.Tests/CodeFixers/WindowFunctionLiteralArgsAnalyzerTests.cs Adds analyzer tests for invalid literal bucket/offset arguments.
tests/ExpressiveSharp.EntityFrameworkCore.IntegrationTests/Infrastructure/WindowFunctionTestBase.cs Adds integration tests covering tie-breaking, framing, and translation-time argument validation.
src/ExpressiveSharp.EntityFrameworkCore.RelationalExtensions/Infrastructure/Internal/WindowFunctionMethodCallTranslator.cs Introduces translation-time validation for invalid window-function arguments.
src/ExpressiveSharp.EntityFrameworkCore.RelationalExtensions/ExpressiveSharp.EntityFrameworkCore.RelationalExtensions.csproj Updates package description to reflect the broader supported feature set.
src/ExpressiveSharp.EntityFrameworkCore.RelationalExtensions.Abstractions/WindowFunction.cs Replaces generic stub exceptions with method-specific guidance for direct invocation.
src/ExpressiveSharp.EntityFrameworkCore.CodeFixers/WindowFunctionLiteralArgsAnalyzer.cs Adds Roslyn diagnostics for invalid literal Ntile and Lag/Lead arguments.
docs/recipes/window-functions-ranking.md Removes experimental warning from ranking recipe docs.
docs/index.md Updates homepage package/feature descriptions for relational extensions.
docs/guide/window-functions.md Expands provider notes, validation docs, and upgrade guidance for window functions.
docs/guide/quickstart.md Refreshes package summary text for relational extensions in the quickstart table.
docs/advanced/limitations.md Reframes limitations docs around provider support instead of experimental status.
README.md Removes experimental wording from the top-level feature list.
CLAUDE.md Updates internal repo notes to reflect non-experimental status and new diagnostics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/guide/quickstart.md Outdated
koenbeuk and others added 3 commits May 3, 2026 18:37
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@koenbeuk koenbeuk merged commit 1becb60 into main May 3, 2026
17 checks passed
@koenbeuk koenbeuk deleted the feat/relational-extensions-stable branch May 3, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants