fix AVG over nullable int?/long? window#67
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes AVG window translation for nullable integer inputs so int?/long? averages are cast to floating-point SQL before aggregation, matching the API’s double? return semantics.
Changes:
- Casts AVG integer arguments to
doubleinstead of the method return type. - Extends float-cast detection to nullable
double?AVG overloads. - Adds an integration test covering nullable
intAVG producing1.5instead of integer-truncated1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/ExpressiveSharp.EntityFrameworkCore.RelationalExtensions/Infrastructure/Internal/WindowFunctionMethodCallTranslator.cs |
Updates AVG translation logic for nullable integer inputs. |
tests/ExpressiveSharp.EntityFrameworkCore.IntegrationTests/Infrastructure/WindowFunctionTestBase.cs |
Adds coverage for nullable integer AVG casting behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PostgreSQL renders the float cast as `::double precision` rather than the `CAST(... AS ...)` keyword, so the literal "CAST" assertion failed only on Postgres. Accept either cast idiom. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.