UnionBy stub had a wrong parameter type#68
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the UnionBy polyfill/interceptor stub to accept an element sequence (IEnumerable<T>) instead of a key sequence (IEnumerable<TKey>), aligning ExpressiveSharp’s intercepted Queryable.UnionBy surface with the actual LINQ API and restoring correct call-site binding.
Changes:
- Corrected
UnionBystub overloads inExpressiveQueryableLinqExtensionsto takeIEnumerable<T>as thesecondparameter. - Updated generator test input + verified snapshot to reflect the corrected
UnionByinterceptor signature. - Added integration tests covering
UnionBy,ExceptBy, andIntersectBycompilation and runtime behavior throughAsExpressive()interception.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/ExpressiveSharp.IntegrationTests/Tests/SetOperationInterceptorTests.cs | Adds regression tests ensuring set-operation interceptors compile and run with correct argument types/semantics. |
| tests/ExpressiveSharp.Generator.Tests/PolyfillInterceptorGenerator/SetOperationTests.UnionBy_GeneratesInterceptor.verified.txt | Updates verified output so generated interceptor signature uses IEnumerable<Order> for second. |
| tests/ExpressiveSharp.Generator.Tests/PolyfillInterceptorGenerator/SetOperationTests.cs | Fixes generator test source for UnionBy to pass an element sequence (IEnumerable<Order>). |
| src/ExpressiveSharp/Extensions/ExpressiveQueryableLinqExtensions.cs | Corrects UnionBy stub overload parameter type from IEnumerable<TKey> to IEnumerable<T>. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.