Fixed incremental cache busting issue#73
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an incremental caching flaw in PolyfillInterceptorGenerator where cross-file type/member changes could leave previously-generated interceptors stale, and adds regression tests to ensure output stays correct while avoiding unnecessary downstream churn on unrelated edits.
Changes:
- Reworks the polyfill interceptor incremental pipeline to recompute on compilation changes and value-gate
AddSourceon equatable generated source data. - Exposes a tracking-name constant (
InterceptorSourcesTrackingName) to support incremental step assertions in tests. - Adds MSTest coverage for (1) cross-file type changes matching a fresh run and (2) unrelated edits not invalidating emitted interceptor sources.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/ExpressiveSharp.Generator.Tests/PolyfillInterceptorGenerator/IncrementalCachingTests.cs | Adds incremental caching regression tests for cross-file edits and unrelated edits. |
| src/ExpressiveSharp.Generator/PolyfillInterceptorGenerator.cs | Fixes incremental caching by recomputing on compilation changes and gating emission via value-equatable generated sources (plus tracked step name). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #71, now targeting the polyfill interceptor generator