Skip to content

Test enhancement#1

Merged
jorgecc merged 2 commits intoEFTEC:masterfrom
peter279k:test_enhancement
Dec 16, 2018
Merged

Test enhancement#1
jorgecc merged 2 commits intoEFTEC:masterfrom
peter279k:test_enhancement

Conversation

@peter279k
Copy link
Copy Markdown
Contributor

@peter279k peter279k commented Dec 16, 2018

Changed log

  • Remove php-5.6 test in Travis CI build.
  • Require php-7.0 at least in composer.json.
  • Enhance Travis CI setting.
  • Remove bootstrap because we can only use the vendor/autoload.php file.
  • Define test namespace in composer.json.
  • Fix indents.

@jorgecc
Copy link
Copy Markdown
Member

jorgecc commented Dec 16, 2018

Can you cancel it?. I agree with the changes; however, I can't limit PHP 5.6 because it is still alive. I know that it's discontinued, but PHP 5 is still king, so there is no reason to not to use PHP 5.6 but the use of new features (that AFAIK this library is not using).

Php trend 16 september

@peter279k
Copy link
Copy Markdown
Contributor Author

@jorgecc, thank you for your reply. I push the latest commit and revert php-5.6 support.

You can check that.

@jorgecc jorgecc merged commit eb06a0f into EFTEC:master Dec 16, 2018
@peter279k peter279k deleted the test_enhancement branch December 16, 2018 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants