chore: use pull_request_target to allow deleting previews from froks#697
Merged
gwarf merged 3 commits intoEGI-Federation:mainfrom Jan 14, 2025
gwarf:fix_preview_deletion_for_forks
Merged
chore: use pull_request_target to allow deleting previews from froks#697gwarf merged 3 commits intoEGI-Federation:mainfrom gwarf:fix_preview_deletion_for_forks
gwarf merged 3 commits intoEGI-Federation:mainfrom
gwarf:fix_preview_deletion_for_forks
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses pull_request_target to delete previews of PRs from forks.
See also https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/
It grants write access using the GITHUB_TOKEN, but it is safe as:
Related issue :
Fix #696