Fix parameters order in POST requests#31
Merged
Merged
Conversation
Sorry about the lack of unit tests in this project. Tested and validated at Résif.
Contributor
Author
|
This fix has been deployed at RESIF and is working fine. a10y is now able to list restricted network's availability. @jbienkowski could you test on your side and apply the PR ? |
sheimers
reviewed
Mar 11, 2024
Contributor
sheimers
left a comment
sheimers
left a comment
There was a problem hiding this comment.
It fails here, from the log:
post_params = [(k for k in Parameters().todict() if k not in exclude]
^
SyntaxError: closing parenthesis ']' does not match opening parenthesis '('
Obviously there is an orphaned '(' left. Should it be removed, or re-added after 'exclude'?
Contributor
Author
|
This is horrible. I'm so sorry. |
Contributor
Author
|
I fixed it and merge in master. |
Contributor
|
Thanks for the fast fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix has been tested in Resif environment.
Please someone check if it works against the #29 issue.