Add support for Draeger data with Pressure Pod information#346
Merged
Add support for Draeger data with Pressure Pod information#346
Conversation
Contributor
Author
|
Closes #193 |
JulietteFrancovich
approved these changes
Jan 20, 2025
Contributor
JulietteFrancovich
left a comment
JulietteFrancovich
left a comment
There was a problem hiding this comment.
Looks good! I have added two comments and have one more general comment: there is quite a lot of code and not a lot of explanation/ documentation. It might be useful to explain what is happening (especially with the different formats) for easier understanding of the code.
psomhorst
force-pushed
the
193_variable_bin_format
branch
from
8ae13b4 to
098dc69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*.bin files from measurements with a pressure pod active results in more medibus fields. This PR adds support for loading these extra fields. One of two formats for the *.bin files is expected, each with different frame size and order of Medibus fields. Further extension in the future is possible.