Detect sample frequency for Draeger data#347
Merged
Conversation
psomhorst
added
enhancement
psomhorst
force-pushed
the
217_detect_sample_frequency_draeger
branch
from
adc66dd to
5a4d666
Compare
psomhorst
force-pushed
the
217_detect_sample_frequency_draeger
branch
from
5a4d666 to
4ade3eb
Compare
JulietteFrancovich
approved these changes
Dec 18, 2024
psomhorst
force-pushed
the
217_detect_sample_frequency_draeger
branch
from
4ade3eb to
64a68d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #217
In this PR, the sample frequency of Draeger data is estimated from the time axis in the data. If a sample frequency is provided during loading, this is used, but a difference between the estimated and provided frequency results in a warning. This unfortunately makes loading between manufacturers inconsistent, but we can work around that.