Skip to content

Apidoc#21

Merged
rakeshSgr merged 15 commits intoELEVATE-Project:masterfrom
ankit1shahu:apidoc
Jun 1, 2022
Merged

Apidoc#21
rakeshSgr merged 15 commits intoELEVATE-Project:masterfrom
ankit1shahu:apidoc

Conversation

@ankit1shahu
Copy link
Collaborator

I have added Api doc and updated packages for users.

application.json:
schema:
"$ref": "#/components/schemas/user/acceptTermsAndConditionResponse400"
"/user/v1/account/verifyMentor":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check this API response

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitpws

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

application.json:
schema:
"$ref": "#/components/schemas/form/readForm400Response"
"/user/v1/mentors/list":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitpws pageNo,pageSize and search text is missing
And in other API's as well if required

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

content:
application.json:
schema:
"$ref": "#/components/schemas/mentor/getMentorList200Resposne"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitpws Count filed is missing in the response

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added count filed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

application.json:
schema:
"$ref": "#/components/schemas/mentor/getMentorList200Resposne"
"/user/v1/userentity/create":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitpws Validate in swagger editor, this API not showing in swagger editor list

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

{
"openapi": "3.0.0",
"info": {
"title": "ML-Core Service API(s)",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitpws this file is not required

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sorry i forgot to delete

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

app.js Outdated
specUrl: "/docs/swagger",
})
);
// app.use("/api-docs", swaggerUi.serve);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitpws remove unnecessary comments

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

const mongoose_autopopulate = require("mongoose-autopopulate");
const mongoose_timestamp = require("mongoose-timestamp");
const mongoose_paginate = require('mongoose-paginate-v2');
const mongoose_paginate = require("mongoose-paginate-v2");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitpws if not require remove mongoose_paginate

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

async update(req) {
const params = req.body;
try {
const updatedProfile = await profileHelper.update(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitpws please verify they should not be able to update the email

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its done please check service file for update method.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already resolved

async list(req) {
const userId = req.decodedToken._id;
try {
console.log("=======>", req.pageNo, req.pageSize, req.searchText, userId);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitpws remove the console.log

routes/index.js Outdated
let validationError;

console.log(".//////////////", req.method);
console.log(".//////////////", req.pageNo, req.pageSize, req.searchText);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitpws - remove this console.log

src/app.js Outdated
app.use(expressFileUpload())

app.get("/api-doc", function (req, res) {
console.log("api");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitpws remove this console.log

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rakeshSgr rakeshSgr merged commit 156b297 into ELEVATE-Project:master Jun 1, 2022
tech-infra pushed a commit that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants