Merged
Conversation
Changed file structure in oteapi-core need to be implemented.
requirements.txt now complies with what is in current oteapi-core. requirements_dev.txt added with extra packages for development mode. Dockerfile updated accoringly. Tests commented out in Dockerfile. Needs fixing in separate issue. Updated paths in imports from oteapi-core according to new structure.
CasperWA
requested changes
Jan 18, 2022
Contributor
CasperWA
left a comment
CasperWA
left a comment
There was a problem hiding this comment.
Beautiful! Thanks @francescalb.
I have only one change suggestion.
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
CasperWA
approved these changes
Jan 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated requirements.txt to comply with what currently is installed from oteapi-core:master.
oteapi is now imported from github:master. This should be updated once the pypi package is updated.
Requirements only needed for development in requirements_dev.txt.
Dockerfile updated accordingly.
Tests commented out in Dockerfile. Need fixing in separate issue.