Conversation
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
- Coverage 69.49% 68.57% -0.93%
==========================================
Files 8 15 +7
Lines 295 420 +125
==========================================
+ Hits 205 288 +83
- Misses 90 132 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@pscff I'll stop messing around here now - feel free to comment on whether you want to implement further changes (or simply do) in the scope of this PR :) |
|
@quaat and @jesper-friis There is some confusion on my side as to the dataresource endpoint, when handling a download and parse strategy. For the |
Add package for defining custom pydantic response-models Include isort, black in dev requiremetns (see git-hooks). Add HTTPValidationError response model. Include 4xx response models at router-level. Use starlette's status codes. Raise an error when session_id cannot be found in the cache. Add Status and Error responses to all endpoints. Use a generic Status Response Model. Move response helper functions to models.response. Add response models to datafilter, mapping, and session.
Fixed app.main for updated routers. Update to oteapi-core v0.1.0. Remove TYPE_CHECKING blocks from code coverage. Change `main._APP` to `main.APP`. Use status codes via `fastapi.status`. Remove dependencies from git hooks as these will be installed and handled by pre-commit.
709d52c to
f7851a4
Compare
Closes #9
Closes #51
Closes #47
The latest commits expect the new
SessionUpdateobject is returned from strategy methods.Note: This is a PR opened by me from the work done by @pscff to implement pydantic data models for the API responses and more. I have done a full overhaul in the latter commits to fully finish and implement the ideas started by @pscff.