Conversation
| # RUN pytest --cov app | ||
|
|
||
| # For debugging: install oteapi locally | ||
| #COPY oteapi-core oteapi-core |
There was a problem hiding this comment.
The local oteapi-core should not be inside oetapi-services. Copy from path to is my suggstion.
| #COPY oteapi-core oteapi-core | |
| # copy oteapi-core from local path | |
| #COPY ../oteapi-core oteapi-core |
Furthermore, this does not allow for runing services locally while developing oteapi-core. That would require mounting the oteapi-core as a volume and pip installing from there.
I have tried to do that but right now the services fail as soon as there is an error, making everything stop.
There was a problem hiding this comment.
Agree, placing oteapi-core inside oteapi-services is not the correct way to do things. It is just a hack that makes it much easier to debug issues within oteapi-core that makes the services crash.
|
|
||
| # For debugging: install oteapi locally | ||
| #COPY oteapi-core oteapi-core | ||
| #RUN pip install -U /app/oteapi-core |
There was a problem hiding this comment.
Installing for development of oteapi-core needs pip install -e . on volume mounted.
There was a problem hiding this comment.
Tried that, but that didn't worked for me.
This is just a hack that makes it easier to debug issues related to oteapi-core. It should not be used in production code which is why it is commented out in this PR.
I agree that it should be removed as soon as we have a better way to debug.
| numpy==1.22.1 | ||
| openpyxl==3.0.9 | ||
| oteapi-core @ git+https://github.com/EMMC-ASBL/oteapi-core.git@4a7f087e464d9ac017aeb5e5a96be659e4816176 | ||
| oteapi-core @ git+https://github.com/EMMC-ASBL/oteapi-core.git@90961930b7c1f83466c28a7e03dc04122a98e812 |
There was a problem hiding this comment.
Couldn't we point to master instead?
3 participants
Uh oh!
There was an error while loading. Please reload this page.