Skip to content

Test Dockerfile in CI/CD#7

Merged
CasperWA merged 21 commits intomasterfrom
cwa/close-4-ci-cd-test-dockerfile
Jan 26, 2022
Merged

Test Dockerfile in CI/CD#7
CasperWA merged 21 commits intomasterfrom
cwa/close-4-ci-cd-test-dockerfile

Conversation

@CasperWA
Copy link
Copy Markdown
Contributor

@CasperWA CasperWA commented Jan 24, 2022

Closes #4
Closes #3
Closes #5

Also: Clean up the repository.

Add routes prefix (`/api/v1`) as a configuration parameter so it can be
overloaded during testing - and also set via environment variables.
Add pytest-cov to dev requirements.

Remove unused publish option (on network host).
@CasperWA CasperWA force-pushed the cwa/close-4-ci-cd-test-dockerfile branch from 7ae685f to 751d604 Compare January 25, 2022 16:59
@CasperWA CasperWA marked this pull request as ready for review January 25, 2022 17:04
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@775b9fa). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #7   +/-   ##
=========================================
  Coverage          ?   69.49%           
=========================================
  Files             ?        8           
  Lines             ?      295           
  Branches          ?        0           
=========================================
  Hits              ?      205           
  Misses            ?       90           
  Partials          ?        0           
Flag Coverage Δ
pytest 69.49% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 775b9fa...cb991bd. Read the comment docs.

Copy link
Copy Markdown
Contributor

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good

@CasperWA CasperWA merged commit 38972f3 into master Jan 26, 2022
@CasperWA CasperWA deleted the cwa/close-4-ci-cd-test-dockerfile branch January 26, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants