Skip to content

Trj/75 add a triplestore and sample endpoint#97

Merged
Treesarj merged 13 commits intomasterfrom
trj/75-add-a-triple-store-to-the-docker-compose-for-mapping-strategy
Apr 1, 2022
Merged

Trj/75 add a triplestore and sample endpoint#97
Treesarj merged 13 commits intomasterfrom
trj/75-add-a-triple-store-to-the-docker-compose-for-mapping-strategy

Conversation

@Treesarj
Copy link
Copy Markdown
Contributor

  • add a triple store to the docker-compose
  • sample query endpoint

@Treesarj Treesarj requested review from CasperWA and kriwiik March 17, 2022 15:38
@Treesarj Treesarj linked an issue Mar 17, 2022 that may be closed by this pull request
@Treesarj Treesarj changed the title Trj/75 add a triplestore Draft:Trj/75 add a triplestore Mar 17, 2022
@Treesarj
Copy link
Copy Markdown
Contributor Author

Need to update the oteapi-core version in requirements for the tests to pass

@Treesarj Treesarj changed the title Draft:Trj/75 add a triplestore Trj/75 add a triplestore and sample endpoint Mar 23, 2022
@Treesarj Treesarj self-assigned this Mar 23, 2022
Copy link
Copy Markdown
Contributor

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the AllegroGraph user details as configuration/settings parameters in the application.
Then they can be accessed by the application as well - if that's necessary?
If it's not necessary, then never mind :)

@Treesarj
Copy link
Copy Markdown
Contributor Author

Add the AllegroGraph user details as configuration/settings parameters in the application. Then they can be accessed by the application as well - if that's necessary? If it's not necessary, then never mind :)

The Triple store config requires the user credentials, so I guess it's not necessary.

@CasperWA
Copy link
Copy Markdown
Contributor

Add the AllegroGraph user details as configuration/settings parameters in the application. Then they can be accessed by the application as well - if that's necessary? If it's not necessary, then never mind :)

The Triple store config requires the user credentials, so I guess it's not necessary.

Okay. Just for the record, what I meant by application settings was this class: https://github.com/EMMC-ASBL/oteapi-services/blob/master/app/main.py#L26:L37

@Treesarj Treesarj marked this pull request as draft March 31, 2022 11:28
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #97 (56bd09e) into master (28cc7f9) will increase coverage by 0.00%.
The diff coverage is 70.00%.

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   69.87%   69.87%           
=======================================
  Files          17       18    +1     
  Lines         468      478   +10     
=======================================
+ Hits          327      334    +7     
- Misses        141      144    +3     
Flag Coverage Δ
pytest 69.87% <70.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/main.py 77.77% <ø> (ø)
app/routers/triplestore.py 70.00% <70.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28cc7f9...56bd09e. Read the comment docs.

@Treesarj Treesarj marked this pull request as ready for review April 1, 2022 09:05
@Treesarj Treesarj merged commit f910fad into master Apr 1, 2022
@Treesarj Treesarj deleted the trj/75-add-a-triple-store-to-the-docker-compose-for-mapping-strategy branch April 1, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a triple store to the docker-compose for mapping strategy

4 participants