Merged
Conversation
When storing to triplestore expected IRIs that are not valid will throw an error. However, it is possible to add a baseiri that should be used for relative iris (i.e. every time and IRI is expected, if it is not valid it will be given the baseiri)
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
Contributor
jesper-friis
left a comment
jesper-friis
left a comment
There was a problem hiding this comment.
Added two suggestions
jesper-friis
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently saving an invalid jsonld to the triplestore does not raise an error
if the jsonld is invalid ( at least if expected IRIs are just literals).
It just passes, there are no warnings, but also nothing is adde to the triplestore.
This needs to be corrected. Question is how?
with rdflib we can parse the graph and add a base (namespace) to the
generated graph and then check if this generated graph contains irs with that namespace
afterwards.
The what do we want to do? Should this be done somewhere different?
Or shold we reeanblae validation.
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.