Skip to content

Feature/fix public transport#117

Merged
floriangc merged 16 commits intodevelopfrom
feature/fix_public_transport
Oct 13, 2022
Merged

Feature/fix public transport#117
floriangc merged 16 commits intodevelopfrom
feature/fix_public_transport

Conversation

@kit4a
Copy link
Collaborator

@kit4a kit4a commented Oct 12, 2022

What has been done:

  • Fix the algo that build PT activities, add a test with several cases
  • Fix the assignment of PT vehicle to user (request method)
  • Small fix on wating_answer behavior
  • Fix set_state_waiting_vehicle
  • Fix the transfer from one line to another line of the same PT layer
  • Fix the available mob service when user has (been) refused (by) a mob service
  • Set "infinite" pickup_dt for all PT and all users

@kit4a kit4a requested a review from floriangc October 12, 2022 14:01
@floriangc floriangc added the enhancement New feature or request label Oct 13, 2022
@floriangc floriangc added this to the v3.0.0 milestone Oct 13, 2022
@floriangc floriangc merged commit 9feb621 into develop Oct 13, 2022
@becarie becarie deleted the feature/fix_public_transport branch May 14, 2024 13:38
assuntaDC pushed a commit to DistLab-Sannio/MnMS that referenced this pull request Jan 27, 2025
* [WIP] Fix add_passenger and _insert_in_activity methods of public transport mob service.

* Fix matching veh -> user PublicTransport

* [WIP] Adjust algo of insert in activity, enrich example to test public transportation.

* Fix waiting answer behavior.

* Fix set_state_waiting_vehicle

* Add comment to explain clean of _user_buffer in matching of abstract mobility service.

* Fix insert in activity and request of public transport.

* Remove example test_public_transport_several_pickups and make a test of it.

* Remove print in test public transport several pickups.

* Fix insert actvity for PT when two activities inserted in the same stopped veh.

* Add test for two insert in activity when veh state is stop.

* Add possibility to transfer from one line to another in the same PT layer.

* Remove from available mobility service the one refused and personal vehicle if traveler is not at home anymore.

* Fix removal refused mobility service when origin is a np array, add error when there is no available mobility service left for a user refused.

* Set pickup_dt for all public transportation mobility services to 24 hours.

Co-authored-by: Florian Gacon <florian.gacon@entpe.fr>
assuntaDC pushed a commit to DistLab-Sannio/MnMS that referenced this pull request Jan 29, 2025
* [WIP] Fix add_passenger and _insert_in_activity methods of public transport mob service.

* Fix matching veh -> user PublicTransport

* [WIP] Adjust algo of insert in activity, enrich example to test public transportation.

* Fix waiting answer behavior.

* Fix set_state_waiting_vehicle

* Add comment to explain clean of _user_buffer in matching of abstract mobility service.

* Fix insert in activity and request of public transport.

* Remove example test_public_transport_several_pickups and make a test of it.

* Remove print in test public transport several pickups.

* Fix insert actvity for PT when two activities inserted in the same stopped veh.

* Add test for two insert in activity when veh state is stop.

* Add possibility to transfer from one line to another in the same PT layer.

* Remove from available mobility service the one refused and personal vehicle if traveler is not at home anymore.

* Fix removal refused mobility service when origin is a np array, add error when there is no available mobility service left for a user refused.

* Set pickup_dt for all public transportation mobility services to 24 hours.

Co-authored-by: Florian Gacon <florian.gacon@entpe.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants