chore(e2e): fix release validation checks

[SantiagoDePolonia]

Summary

• preserve real release e2e scenario exit codes in the runner
• serialize execution-plan effective feature flags with lower-case JSON keys and cover it with an API test
• keep the exact-cache release scenario reply short so it fits its token budget while preserving per-run isolation via request IDs and user path

Tests

• go test ./internal/core ./internal/executionplans ./internal/admin
• bash -n tests/e2e/run-release-e2e.sh
• tests/e2e/run-release-e2e.sh --list
• pre-commit hooks: go unit test, make lint, hot-path performance guard

Summary by CodeRabbit

• Bug Fixes

  • Standardized execution plan API response format to use lowercase field names for feature flags (cache, audit, usage, guardrails, fallback).

• Tests

  • Enhanced validation of feature flag response format in execution plan tests.
  • Improved test infrastructure reliability for script-based test execution.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b214e5cd-6f11-4efa-8406-a81a43d42863

📥 Commits

Reviewing files that changed from the base of the PR and between 824a135 and fd54665.

📒 Files selected for processing (4)

• internal/admin/handler_executionplans_test.go
• internal/core/execution_plan.go
• tests/e2e/release-e2e-scenarios.md
• tests/e2e/run-release-e2e.sh

---

📝 Walkthrough

Walkthrough

This PR adds explicit JSON struct tags to the ExecutionFeatures fields, ensuring lowercase serialization, and updates the corresponding test to validate the JSON response uses lowercase keys. Additionally, e2e test scripts are updated to adjust cache reply handling and improve timeout exit-status management.

Changes

Cohort / File(s)	Summary
Core Struct & Test Validation internal/core/execution_plan.go, internal/admin/handler_executionplans_test.go	Added explicit JSON struct tags (json:"cache", json:"audit", json:"usage", json:"guardrails", json:"fallback") to ExecutionFeatures fields. Test now validates effective_features response unmarshals into map[string]bool with lowercase keys and confirms Go-style exported keys are absent.
E2E Test Scripts tests/e2e/release-e2e-scenarios.md, tests/e2e/run-release-e2e.sh	Updated QA_CACHE_REPLY environment variable from suffix-specific token to non-suffixed QA_CACHE_EXACT_OK. Improved run_with_timeout() to explicitly set status=0 on successful wait and only assign status=$? on failure.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• chore: updated release e2e scenarios and added runner #203 — Overlapping modifications to tests/e2e/run-release-e2e.sh and tests/e2e/release-e2e-scenarios.md, specifically the run_with_timeout() behavior and environment variable handling.

Poem

🐰 Tags of JSON, lowercase and bright,
Features now marshal just right,
Tests verify the keys align,
Exit codes and timeouts shine,
Cache and audit in perfect flight!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore(e2e): fix release validation checks' is closely related to the main objectives of the PR, which involve fixing release e2e scenario exit code handling, JSON serialization of feature flags, and cache token optimization.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/release-e2e-fixes

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[SantiagoDePolonia]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.