fix(release): publish draft release without checkout#359
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request modifies the release workflow to publish drafted releases with tag verification enabled. The "Publish drafted release" step in the ChangesRelease Publication Workflow
Possibly Related PRs
Poem
Estimated Review Effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR updates the release workflow publish step. The main change is:
Confidence Score: 4/5This should be fixed before merging.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(release): publish draft release with..." | Re-trigger Greptile |
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: gh release edit "$GITHUB_REF_NAME" --draft=false --verify-tag | ||
| run: gh release edit "$GITHUB_REF_NAME" --repo "$GITHUB_REPOSITORY" --draft=false --verify-tag |
There was a problem hiding this comment.
gh release edit does not accept --verify-tag; that option is not listed for the edit command. On the tag publish path, this step can still fail during CLI argument parsing before the draft release is published, even though --repo now avoids local .git discovery.
| run: gh release edit "$GITHUB_REF_NAME" --repo "$GITHUB_REPOSITORY" --draft=false --verify-tag | |
| run: gh release edit "$GITHUB_REF_NAME" --repo "$GITHUB_REPOSITORY" --draft=false |
There was a problem hiding this comment.
Checked this against the current GitHub CLI docs and local gh help. gh release edit does support --verify-tag, and --repo is an inherited flag for selecting the repository:
- https://cli.github.com/manual/gh_release_edit
gh release edit --helpongh version 2.92.0lists both--verify-tagand-R, --repo.
I also ran this from /tmp, outside any git repository:
gh release edit __gomodel_probe_missing_release__ --repo ENTERPILOT/GoModel --draft=false --verify-tagIt accepted the flags and failed with release not found, not an unknown flag or .git discovery error. Leaving the command unchanged.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
--repo "$GITHUB_REPOSITORY"togh release editin the release publish job..gitdirectory.Context
The
v0.1.34release run failed inPublish GitHub releasewith:Failed run: https://github.com/ENTERPILOT/GoModel/actions/runs/26556449768
Verification
go run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/release.ymlgit diff --checkSummary by CodeRabbit