feat: Phase 4 — CLI and S3 (#139)#155
Merged
emmanuelmathot merged 1 commit intos1-rtcfrom Apr 2, 2026
Merged
Conversation
- Add validate-s1 CLI subcommand (Pydantic schema validation) - S3 output support in s1_ingest.py via open_zarr_group/path_exists - Consolidation follows S2 pattern: root.store passed to zarr.consolidate_metadata - E2E CLI test: ingest-s1 → ingest-s1-conditions → consolidate-s1 → validate-s1 → xarray readback
6 tasks
emmanuelmathot
commented
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4 — CLI and S3
Closes the Phase 4 checklist in #139.
Changes
validate-s1CLI subcommand (cli.py)S1RtcRootPydantic schema--verboseshows orbit directions, data arrays, coordinates, and conditions statusS3 output support (s1_ingest.py)
create_s1_store/ingest_s1tiling_acquisition/ingest_s1tiling_conditionsnow useopen_zarr_group()andpath_exists()fromfs_utils, making them S3-transparentconsolidate_s1_storefollows the S2 pattern: opens the store, passesroot.storetozarr.consolidate_metadata()E2E CLI test (test_cli_e2e.py)
ingest-s1→ingest-s1-conditions→consolidate-s1→validate-s1→ xarray readbackvalidate-s1on an invalid store returns non-zeroingest-s1,ingest-s1-conditions,consolidate-s1,validate-s1)CLI subcommands (complete set after Phase 3 + 4)
ingest-s1ingest-s1-conditionsconsolidate-s1validate-s1S1RtcRootTest results