Update documentation for Sentinel-2 optimized conversion #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `initialize_crs_from_dataset` function to extract CRS from dataset metadata. - Updated S2 optimization commands to include new CRS handling. - Removed unused arguments related to geometry and meteorology groups. - Added comprehensive tests for CRS initialization from various sources.
emmanuelmathot
changed the title
Contributor
|
lgtm! maybe we should get #75 in first? |
…eprecate V0 structure
Contributor
|
I think https://github.com/EOPF-Explorer/data-model/blob/main/docs/examples.md needs to be updated too |
lhoupert
reviewed
Dec 3, 2025
lhoupert
reviewed
Dec 3, 2025
…evels in GeoZarr converter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated documentation to clearly explain the structural differences between the deprecated V0 converter (
create_geozarr_dataset) and the current V1 converter (convert_s2_optimized) for Sentinel-2 data.Key Changes
docs/converter.md: Added "V0 vs V1 Converter: Key Differences" section with ASCII diagrams showing:
/r10m/0,/r10m/1, etc.)/r10m,/r20m,/r60m,/r120m,/r360m,/r720m)docs/architecture.md: Updated to reflect functional programming approach and xarray downsampling
docs/geozarr-minispec.md: Documented dual convention support (Zarr Multiscales + GeoZarr TMS)
docs/api-reference.md: Added S2 optimization functions documentation
Why This Matters
Addresses confusion about why V1 doesn't produce nested pyramid levels (r10m/0, r10m/1, etc.) like V0. V1's approach:
Migration Note
V0 is deprecated. Data-pipeline v1.0.0 will use V1 converter exclusively.