This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Update Zipkin connection retry - 2.1.x #10486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
EPE-933 [GitHub:issue:10255]:
on networks like EOS Mainnet, 9 attempts is very small and useless for intermittent failures like running a zipkin upgrade. For production use, need to work more like:
telemetry-urlis a DNS name that points to multiple A or AAAA records, nodeos should try all the addreses returned before giving up.Notes:
fc submoduleUpdate Zipkin connection retry - 2.1 fc#201Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Documentation Additions
Method handle_sighup() defined in zipkin is to handle signal SIGHUP, and this method is not called directly from the original SIGHUP signal handler but from other handlers, e.g., handle_sighup() of net_plugin, one of the mandatory plugins, can be used to forward signal SIGHUP by calling zipkin's handle_sighup().
Add a new option:
telemetry-retry-interval-us, optional parameter, specifies the retry interval for connecting to zipkin with default value set to 30000000