This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Merged
Conversation
arhag
reviewed
May 10, 2018
| * @tparam Translated - the list of transcribed wasm parameters | ||
| */ | ||
| template<typename Ret, typename... Inputs, typename ...Translated> | ||
| struct intrinsic_invoker_impl<Ret, std::tuple<const fc::time_point_sec&, Inputs...>, std::tuple<Translated...>> { |
Contributor
There was a problem hiding this comment.
Since the time_point_sec specialization is not needed anymore and is being removed, it should also be removed from binaryen.hpp (see line 552). Also the native_to_wasm and wasm_to_rvalue_types related to fc::time_point_sec or its const reference should be removed from wavm.hpp, and the equivalent in binaryen.hpp (convert_native_to_literal for the const fc::time_point_sec&) should be removed as well.
Contributor
There was a problem hiding this comment.
time_point_sec is still used for ABI in cases where second resolution is good enough.
Likely unneeded for intrinsics though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added alignment checks and slow path for array types. Removed one specialization that is no longer being used and added overlap checks for memcpy.